KAFKA-20642: Support character ranges in Kafka shell globs#22430
Open
Russole wants to merge 2 commits into
Open
KAFKA-20642: Support character ranges in Kafka shell globs#22430Russole wants to merge 2 commits into
Russole wants to merge 2 commits into
Conversation
Author
|
Hi @chia7712 , could you please take a look when you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the TODO in
GlobComponentto handle character rangesin Kafka shell glob components.
TODO Link:
kafka/shell/src/main/java/org/apache/kafka/shell/glob/GlobComponent.java
Line 110 in f2f3110
GlobComponentalready supports*,?, and{a,b}patterns, butcharacter classes were not handled. This change translates glob
character classes into Java regular expression character classes,
including ranges and negated classes such as
[0-9],[abc],[!abc],and
[^abc].Malformed character classes such as unterminated or empty classes are
rejected consistently with other malformed glob patterns.
Unit tests were added in
GlobComponentTestfor regex translation,matching behavior, and malformed character classes. I also ran
./gradlew :shell:test --tests org.apache.kafka.shell.glob.GlobComponentTest.